- Issue created by @plopesc
- Assigned to sjothivelu@valleywater.org
- Merge request !7984rename UserNavigationBlock to NavigationUserBlock → (Closed) created by sjothivelu@valleywater.org
- Status changed to Needs work
6 months ago 12:31am 10 May 2024 - 🇪🇸Spain plopesc Valladolid
Thank you for working on this one!
Would be great if you could merge 11.x branch into the MR branch to fix the broken tests. They're unrelated to the issue, but to the specific 11.x HEAD you used as base.
While we are here, would be great if you could remove the
moduleHandlerproperty from theNavigationUserBlockclass.You can completely remove __construct() & create() methods. We could also get rid of the reference to
ContainerFactoryPluginInterfacein the class definition.Thank you!
- First commit to issue fork.
- Issue was unassigned.
- Status changed to Needs review
6 months ago 9:08pm 15 May 2024 - 🇨🇦Canada m4olivei Grimsby, ON
I've merged 11.x and made the changes requested in #6. Tests are now passing.
Ready for review.
- Status changed to RTBC
6 months ago 5:06am 16 May 2024 - 🇪🇸Spain plopesc Valladolid
Thank you both for taking care of it!
I think we can mark this as RTBC.
- 🇬🇧United Kingdom catch
Committed/pushed to 11.x and cherry-picked back through to 10.3.x, thanks!
- Status changed to Fixed
6 months ago 12:05pm 21 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.