SAML Settings page gets fatal error in a new installation

Open on Drupal.org →

Created on 8 May 2024, 9 months ago

Updated 27 May 2024, 8 months ago

I just installed saml_sp 4.x-dev and enabled the module, then tried to navigate to /admin/config/people/saml_sp - the SAML Settings page. I get a fatal error:

The website encountered an unexpected error. Please try again later.
Error: Call to a member function get() on null in Drupal\saml_sp\Form\SamlSpConfig->isOverridden() (line 61 of modules/contrib/saml_sp/src/Form/SamlSpConfig.php).
Drupal\saml_sp\Form\SamlSpConfig->isOverridden() (Line: 74)
Drupal\saml_sp\Form\SamlSpConfig->overriddenValue() (Line: 227)
Drupal\saml_sp\Form\SamlSpConfig->buildForm()

The line in isOverridden() :

    return $this->configFactory->get('saml_sp.settings')->hasOverrides($name);

There is no configFactory because the parent __construct() from ConfigFormBase is overridden by SamlSpConfig. If I combine the two, it works.

🐛 Bug report

Status

Fixed

Version

4.0

Component

Code

Created by

🇺🇸United States brad.bulger

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!52SAML Settings page gets fatal error in a new installation
Merged
🇺🇸United States jrglasgow
updated 8 months ago

Comments & Activities

Issue created by @brad.bulger
Comment 9 months ago →
🇺🇸United States brad.bulger
I hope I did that properly, I'm still new to using issue forks instead of patches.
First commit to issue fork.
Merge request !52merge constructor of Drupal\Core\Form\ConfigFormBase into → (Merged) created by jrglasgow
Status changed to Fixed 8 months ago7:49pm 13 May 2024
Comment 8 months ago →
🇺🇸United States jrglasgow Idaho
@brad.bulger Drupal.org like to have a new branch with the issue Id included in the branch name, then it is more useful if you create a merge request. Then it is easier for me to approve and merge the merge reqeuest.
Comment 8 months ago →
🇺🇸United States brad.bulger
I couldn't figure out how to do it, sorry.
Comment 8 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024