\Drupal\Core\Plugin\DefaultLazyPluginCollection::setInstanceConfiguration() assumes that $configuration results in the same plugin instance

I've filed this issue against 10.3.x because it occurs due to the 10.2 to 10.3 upgrade but it is also present in 11.x

I'm not able to run the tests-only job for some reason. But when I do locally, I get

Failed asserting that Double\ConfigurableInterface\P1 Object (...) is not an instance of interface "Drupal\Component\Plugin\ConfigurableInterface".

Which sounds like a Prophecy mixup, not an actual working assertion.

@alexpott am I overthinking it? The change looks good

I think there are permissions issues on the test only job when the MR was opened by a core committer.

@tim.plunkett thanks for the review - it's the expected failure because we're doing:

    $configurable_plugin = $this->prophesize(ConfigurableInterface::class);
    $nonconfigurable_plugin = $this->prophesize(PluginInspectionInterface::class);

So these are Prophecy classes that implement the respective interface.

@catch that would explain it!

@alexpott I would have thought the `->reveal()` calls would have helped, but fair enough

Comment nit, otherwise LGTM.

Nice catch @longeave given it was just a nit back to rtbc.

This is eligible for backport to 10.2.x under the bugfix policy but given it has only arisen in 10.3.x not sure it's worth it. Feel free to reopen for backport if this is incorrect.

Committed and pushed 926d069c2c to 11.x and 55463c9ef0 to 11.0.x and b7c0549a3c to 10.4.x and ef095f9bd2 to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.