Rename book.memory_cache to cache.book_memory

Created on 7 May 2024, 8 months ago
Updated 19 September 2024, 3 months ago

Problem/Motivation

Core cache backends are supposed to follow the naming pattern cache.CACHE_NAME, because the latter part is automatically converted into the bin name. By having a cache named book.memory_cache, this creates the generic "memory_cache" bin which could lead to collisions if other modules take an example from Book.

Steps to reproduce

Create a module with the my_module.memory_cache service and try getting that bin from the cache factory service.

Proposed resolution

Rename the cache to cache.book_memory

Remaining tasks

Cache should only be used internally, so I don't think this needs a CR.

User interface changes

None

API changes

None, this cache should not be considered public API

Data model changes

None

πŸ“Œ Task
Status

Fixed

Version

2.0

Component

Code

Created by

πŸ‡§πŸ‡ͺBelgium kristiaanvandeneynde Antwerp, Belgium

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024