Contrib.social

Run PHPStan Checks on staged updates

Open on Drupal.org →
Created on 3 May 2024, 8 months ago
Updated 7 May 2024, 8 months ago

Problem/Motivation

If a module is not careful with backwards compatibility it could break other modules that depend on it.

Or a module could declare dependency on another module but not be careful about the version constraint which could cause a error when it's dependency had a new minor.

Steps to reproduce

Proposed resolution

Create a sub-module or config switch that enables running PHPStan checks on staged updates

Some ideas

  1. Since phpstan will likely not be enabled in the active project it could installed on the stage and then remove before committing the changes.
  2. You might need to compare the results with the active directory to see if the problem were introduced in the stage version.

    Or analyse the stage right after it is created and compare in status check and pre-apply. Sort of like \Drupal\package_manager\Validator\LockFileValidator

  3. Might want to only warn if the module containing the update is not installed(in the Drupal sense)
  4. Should this be a warning or an error?
  5. Should this be in effect for Project Browser also?

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request
Status

Active

Component

Code

Created by

🇺🇸United States tedbow Ithaca, NY, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024