- Issue created by @soutams
- ๐ฌ๐งUnited Kingdom aaron.ferris
aaron.ferris โ made their first commit to this issueโs fork.
- ๐ฌ๐งUnited Kingdom aaron.ferris
According to autologout_post_update_8014 this should be set as 'status'. I wonder if it's possible for this config to be updated to still be empty, without digging through the form/config we could set a fallback in case the $status is empty?
MR raised.
- Merge request !56Issue #3445118: add a fallback to the message type โ (Open) created by aaron.ferris
- Status changed to Needs review
8 months ago 2:41pm 3 May 2024 - ๐ฎ๐ณIndia soutams
I can see the MR got failed. is it possible to share any patch for the issue?
- ๐ฎ๐ณIndia aman1248
Amandeep123 โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia aman1248
Hi @jrglasgow,
I've made the necessary updates to merge request !56, resolving all the CS errors. As you can see, PHPCS now has a green tick across the board.
Thanks - ๐ฎ๐ณIndia aman1248
@soutams, the error for MR! is still there. But there were some cs warning which was a quickfix, which I have made. I am yet not aware about the unit test cases. So I worked only on the some warnings. Please & Thank You!!
- ๐ฌ๐งUnited Kingdom aaron.ferris
The failure is because, I believe, the D9 PHP unit tests are using PHP7.4.
- ๐ฎ๐ณIndia soutams
thanks for your comment.
We are using drupal 10 and php version is 8.1.24.
Can you please provide a patch for the fix?
- ๐ฌ๐งUnited Kingdom aaron.ferris
Sure, as attached (this will include the phpcs changes from @Amandeep123)
- First commit to issue fork.
- ๐ฎ๐ณIndia aman1248
"Hello @Rajeshreeputra, your code successfully achieved the green checkmark on D9. Thank you.
-
japerry โ
committed 5e5d28e0 on 2.x
Issue #3445118 by aaron.ferris: Argument #1 ($type) must be of type...
-
japerry โ
committed 5e5d28e0 on 2.x
- Status changed to Fixed
28 days ago 11:45pm 21 November 2024 -
japerry โ
committed 5e5d28e0 on 8.x-1.x
Issue #3445118 by aaron.ferris: Argument #1 ($type) must be of type...
-
japerry โ
committed 5e5d28e0 on 8.x-1.x
Automatically closed - issue fixed for 2 weeks with no activity.