- Issue created by @kubrick
- Merge request !25Make lazy loading more like the native browser behavior β (Open) created by kubrick
- Status changed to Needs review
6 months ago 8:45am 6 May 2024 - π³π±Netherlands seanB Netherlands
This seems to make sense! Thanks for the issue. I will check the PR this week and try to get this in.
- Status changed to RTBC
6 months ago 5:38pm 20 May 2024 - πΊπΈUnited States smustgrave
Reading the article on https://web.dev/articles/browser-level-image-lazy-loading#distance-from-... this appears to make sense.
- Status changed to Needs work
about 1 month ago 11:55am 3 October 2024 - π³π±Netherlands seanB Netherlands
Looking at this again, I guess this is a tradeoff between initial loading times and perceived performance while scrolling.
Could we maybe make this configurable with a link to https://web.dev/articles/browser-level-image-lazy-loading#distance-from-... in the settings page? I would be happy to default to what chrome does, but I can think of some cases for media rich sites where you might want a smaller offset.
- π§πͺBelgium kubrick
I'd be ok with making it configurable. Which way should be the default behavior?
The current configuration for the module links to "Generate image styles" page, adding the option there feels out of place to me.
While making it part of the display config might make it too granular - I'd think I'd prefer it to be a global setting. - π³π±Netherlands seanB Netherlands
I agree this should be a global setting. Added this to the config page we have right now is a bit weird, but I guess I can live with that.
The default should be what chrome does. I don't think this is something lots of people think about. I just know at least 1 example of a site that I would like to have a lower default for performance, so that is why I chose 300 in the first place :)
We should have an update hook to set it to our new default, for the example site I would want a lower default for, I can change it manually.
- π³π±Netherlands seanB Netherlands
Thanks for the changes, this looks good! I will try to test it shortly. If other people can check this out and RTBC that would also help!