RedirectSubscriber blocking CSS

Created on 30 April 2024, 9 months ago

Problem/Motivation

When CSS aggregation is turned on. Data Policy redirects users to the policy page, but it also redirects the CSS/JS request. This means the resulting page has no styling. This effectively breaks the site, unless the user works out how to accept the policy without any styling.

Steps to reproduce

Enable CSS and JS aggregation for the site: /admin/config/development/performance
Create/edit a data policy to trigger the policy redirect.
Sign-in as a non-admin user that does not have the 'without consent' permission.

You should be redirected to the data policy page and see that there is no styling, which will look like the attached image.

Proposed resolution

I have written a patch that skips the redirect on:

'image.style_private'
'system.css_asset'
'system.js_asset'

These are the 3 routes that appeared during my testing, which I believe shouldn't be redirected.

🐛 Bug report

Status

Active

Version

2.0

Component

Code

Created by

scambler

Live updates comments and jobs are added and updated live.

Merge Requests

!35RedirectSubscriber blocking CSS
Merged
vnech
updated 20 days ago

Comments & Activities

Issue created by @scambler
Comment 9 months ago →
scambler
First commit to issue fork.
Merge request !35Issue #3444427 by scambler: Prevent blocking CSS by RedirectSubscriber → (Merged) created by vnech
Comment about 1 month ago →
vnech
Comment about 1 month ago →
vnech
The patch 🐛 RedirectSubscriber blocking CSS Active was ported to PR.

Comment 20 days ago →

System Message

vnech → committed 658e31c7 on 2.0.x

Issue #3444427 by scambler: Prevent blocking CSS by RedirectSubscriber

Comment 20 days ago →
🇺🇦Ukraine ribel 🇺🇦Lviv
The fix was merged and released in version 2.0.5
Thank you, for reporting and fixing this issue.
Comment 6 days ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024