- Issue created by @esomething
- Assigned to esomething
- Merge request !118Issue 3444258 : Validate rule before calling getParentEntity → (Merged) created by esomething
- Issue was unassigned.
- First commit to issue fork.
- Status changed to Needs review
7 months ago 7:14am 30 April 2024 - 🇨🇦Canada mandclu
Thanks for identifying this, and for providing a fix. I updated the code to resolve the issues identified by the CI, and I refactored the new validateRule() method to make the logic easier to follow.
Please validate that the result still works for your use case.
Thank you for doing the code cleanup. I've created patches but this was my first MR.
It all looks good to me. I just made a couple of minor changes to the comments in the code to reflect the refactoring.
-
mandclu →
committed 236f9c98 on 4.1.x authored by
esomething →
Issue #3444258 by mandclu, esomething: getParentEntity in SmartDateRule...
-
mandclu →
committed 236f9c98 on 4.1.x authored by
esomething →
- Status changed to Fixed
7 months ago 12:25pm 3 May 2024 - 🇨🇦Canada mandclu
Great. Merged in, and should have a new release out shortly.
- 🇨🇦Canada mandclu
@esomething please don't open a new MR on an issue that's already merged. Your changes seem worthwhile so please open a new issue for them.
Automatically closed - issue fixed for 2 weeks with no activity.