Contrib.social

PHPCS errors from 3310884

Open on Drupal.org →
Created on 27 April 2024, 7 months ago
Updated 15 May 2024, 6 months ago

Problem/Motivation

Fixes issue ✨ Ability to clear keyword/search filter with one click Needs work seems to have introduced some new PHPCS issues:

FILE: ...ct_browser-3443929/tests/src/FunctionalJavascript/ProjectBrowserUiTest.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
  980 | ERROR | [x] Visibility must be declared on method
      |       |     "testClearKeywordSearch" (Drupal.Scope.MethodScope.Missing)
  985 | ERROR | [x] Whitespace found at end of line
      |       |     (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine)
 1000 | ERROR | [x] Whitespace found at end of line
      |       |     (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...oject_browser-3443929/src/Plugin/ProjectBrowserSource/MockDrupalDotOrg.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 89 | ERROR | [x] Multi-line function declaration not indented correctly;
    |       |     expected 2 spaces but found 3
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.Indent)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...browser-3443929/src/EventSubscriber/DisableAddNewModuleRouteSubscriber.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 21 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY

Steps to reproduce

See pipeline output: https://git.drupalcode.org/issue/project_browser-3443929/-/jobs/1453514

Proposed resolution

Correct PHPCS errors.

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇮🇪Ireland lostcarpark

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024