Remove code that hacks around fixed core issue 2904467

Created on 26 April 2024, 11 months ago
Updated 29 August 2024, 7 months ago

In src/Plugin/Commerce/ShippingMethod/USPSBase.php in the preparePluginDefinition() function there is a todo to remove code once core issue #2904467: Plugins do not preserve integer keys when parsing annotations β†’ is fixed. It is now fixed so this code should be adjusted.

πŸ“Œ Task
Status

Needs review

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States rhovland Oregon

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @rhovland
  • Pipeline finished with Success
    7 months ago
    Total: 137s
    #268700
  • Status changed to Needs review 7 months ago
  • πŸ‡ΊπŸ‡ΈUnited States rhovland Oregon

    Removed the code that strips the _ from the start of the shipping method plugin service ids and changed the service IDs in the annotations back to integers.

    I'm wondering if maybe we should remove the alphabetical sort too and just sort the annotations by hand. That code seems to run 10-20 times everytime I load a page with a shipping rate selection list in it.

Production build 0.71.5 2024