- Issue created by @dpi
- π¦πΊAustralia dpi Perth, Australia
Set to major since its a "dataloss" problem.
- πΊπΈUnited States tim.tripp
This kind of issue is difficult to fix because of the way CKEditor 5 handles links. The entire
<a href="http://google.com" class="myclass"><i class="fa-brands fa-accusoft fa-7x"> </i></a>
is seen by the editor as a single widget, an icon with alinkHref
attribute. Because the link is only an attribute of icon and not an object of its own, I don't actually know how I can attach classes to it. I can possibly add alinkClasses
attribute to the icon but that doesn't solve the problem of other attributes liketarget="_blank"
that may exist on the link still getting discarded. - πΊπΈUnited States tim.tripp
I'll look into ways to make the editor see them as separate, like it does when there's more than just the icon inside the link, but I'm afraid of causing other issues when messing with how the editor sees links. Right now the way to mitigate this would be to put something else inside the link so it's not just the icon.
- Status changed to Needs work
7 months ago 6:49pm 29 April 2024 - πΊπΈUnited States tim.tripp
Hi @dpi, please verify whether this patch stops the attribute loss.
- Status changed to Needs review
6 months ago 8:46pm 24 May 2024 -
timurtripp β
committed a64dfc5c on 1.x
Issue #3443627: Adds integration plugins
-
timurtripp β
committed a64dfc5c on 1.x
- Status changed to Fixed
6 months ago 10:45pm 3 June 2024 - πΊπΈUnited States tim.tripp
Appreciate you reviewing @matthiasm11! Marking as resolved.
Automatically closed - issue fixed for 2 weeks with no activity.