- Issue created by @rhovland
- Merge request !2Issue #3443624 Configuration for using Gitlab CI is missing → (Merged) created by rhovland
- last update
8 months ago 8 pass - last update
8 months ago 2 fail - last update
8 months ago 8 pass - last update
8 months ago 8 pass - last update
8 months ago 8 pass - 🇮🇱Israel jsacksick
The remaining phpcs issue is annoying... The previous phpcs.xml configuration ignored those... perhaps we simply need phpcs:disable and then phpcs:enable after the problematic lines... Not sure if there is a way to disable this for annotations only.
- 🇺🇸United States rhovland Oregon
It might be something we want to get fixed upstream in the base config since I'm sure there are other instances of annotations being longer than than the max length allowed in the rules. Unfortunately it seems we cannot inherit rules for phpcs so if we define our own we have to keep it in sync with upstream.
- last update
8 months ago 8 pass - Status changed to Needs review
8 months ago 4:46pm 26 April 2024 - 🇺🇸United States rhovland Oregon
So it seems there is already an exclusion rule for translations in annotations here https://git.drupalcode.org/project/coder/-/blob/8.3.x/coder_sniffer/Drup...
The rule looks for "Translation" not "translation". I fixed the capitalization and now it passes.
- 🇺🇸United States rhovland Oregon
Huh weird I realized that the display here in this issue of what merge request test versions ran (D9.5) doesn't match what actually ran (D10.2)
- 🇺🇸United States rhovland Oregon
So I asked in slack and the infrastructure maintainers told me it's because those are DrupalCI tests that are running automatically. Once this is committed they recommend disabling DrupalCI
- Status changed to RTBC
4 months ago 7:38pm 28 August 2024 -
jsacksick →
committed 8672f753 on 8.x-1.x authored by
rhovland →
Issue #3443624 Configuration for using Gitlab CI is missing
-
jsacksick →
committed 8672f753 on 8.x-1.x authored by
rhovland →
- Status changed to Fixed
4 months ago 10:55pm 29 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.