Contrib.social

Content Blocks do not include libraries attached to the block

Open on Drupal.org →
Created on 24 April 2024, 7 months ago
Updated 10 May 2024, 7 months ago

Problem/Motivation

The ContentBlockProcessor uses Drupal\Core\Render\Renderer::renderRoot() instead of render() resulting in libraries not being attached. In fact, I think anything in #attached won't be processed since it's rendering in an isolated render context.

Steps to reproduce

  • Create a custom block type
  • Override the new block type template and include a library that wouldn't otherwise be included on Gutenberg-enabled pages (using {{ attach_library('themename/libraryname') }}.
  • Add the block in Gutenberg as a Content Block
  • Search the rendered page markup for the library's associated css/js assets - they won't be there.

Proposed resolution

Just use Drupal\Core\Render\Renderer::render()? That's how we render DrupalBlocks so it seems appropriate for content blocks - unless there was a reason for renderRoot in this case?

Either way, MR incoming and we can discuss further after!

🐛 Bug report
Status

Fixed

Version

3.0

Component

Code

Created by

🇨🇦Canada drclaw

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @drclaw
  • Merge request !122Uss render() instead of renderRoot() to ensure attachments make it on the page → (Merged) created by drclaw
  • Pipeline finished with Success
    7 months ago
    Total: 419s
    #155871
  • Comment 7 months ago →
    🇵🇹Portugal marcofernandes

    Good find! I wonder why I've choose ::renderRoot and not ::render like we do for DrupalBlockProcessor... 🤔

  • Pipeline finished with Success
    7 months ago
    Total: 279s
    #156683
  • Comment 7 months ago →
    🇨🇦Canada drclaw

    Choo Choo!

  • Status changed to Fixed 7 months ago
  • Comment 7 months ago →
    🇵🇹Portugal marcofernandes
  • Comment 7 months ago →
    🇵🇹Portugal marcofernandes
  • Comment 7 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Failed
    6 months ago
    Total: 251s
    #173246
  • Pipeline finished with Success
    6 months ago
    Total: 178s
    #173256
  • Pipeline finished with Skipped
    6 months ago
    #173777
  • Pipeline finished with Failed
    6 months ago
    Total: 227s
    #175503
  • Pipeline finished with Success
    5 months ago
    Total: 579s
    #214289
  • Pipeline finished with Success
    5 months ago
    Total: 581s
    #214292
  • Pipeline finished with Canceled
    4 months ago
    Total: 151s
    #225806
  • Pipeline finished with Failed
    4 months ago
    Total: 967s
    #225809
  • Pipeline finished with Failed
    4 months ago
    Total: 471s
    #225868
  • Pipeline finished with Success
    4 months ago
    Total: 826s
    #235143
  • Pipeline finished with Failed
    4 months ago
    Total: 299s
    #239584
  • Pipeline finished with Failed
    4 months ago
    #239679
  • Pipeline finished with Success
    4 months ago
    #239684
  • Pipeline finished with Success
    4 months ago
    #239720
  • Pipeline finished with Success
    4 months ago
    Total: 303s
    #239745
  • Pipeline finished with Failed
    4 months ago
    Total: 325s
    #239805
  • Pipeline finished with Success
    4 months ago
    Total: 413s
    #239813
  • Pipeline finished with Failed
    4 months ago
    Total: 369s
    #239841
  • Pipeline finished with Success
    4 months ago
    Total: 361s
    #239847
  • Pipeline finished with Success
    4 months ago
    #245635
  • Pipeline finished with Success
    3 months ago
    Total: 569s
    #254731
  • Pipeline finished with Canceled
    3 months ago
    Total: 295s
    #254765
  • Pipeline finished with Canceled
    3 months ago
    #254778
  • Pipeline finished with Success
    3 months ago
    Total: 339s
    #254780
  • Pipeline finished with Success
    3 months ago
    #254792
  • Pipeline finished with Success
    about 2 months ago
    Total: 282s
    #297846
  • Pipeline finished with Success
    about 2 months ago
    Total: 322s
    #297853
  • Pipeline finished with Success
    about 2 months ago
    Total: 146s
    #297991
  • Pipeline finished with Success
    about 2 months ago
    Total: 148s
    #297995
  • Pipeline finished with Success
    about 2 months ago
    Total: 153s
    #299217
  • Pipeline finished with Success
    about 2 months ago
    Total: 148s
    #300310
  • Pipeline finished with Success
    about 2 months ago
    Total: 151s
    #301307
  • Pipeline finished with Success
    about 2 months ago
    Total: 140s
    #303459
  • Pipeline finished with Success
    about 2 months ago
    Total: 172s
    #303829
  • Pipeline finished with Canceled
    about 1 month ago
    Total: 72s
    #305600
  • Pipeline finished with Failed
    about 1 month ago
    Total: 737s
    #305602
  • Pipeline finished with Canceled
    about 1 month ago
    Total: 413s
    #305611
  • Pipeline finished with Success
    about 1 month ago
    Total: 642s
    #305620
  • Pipeline finished with Failed
    about 1 month ago
    Total: 156s
    #312759
  • Pipeline finished with Success
    about 1 month ago
    Total: 204s
    #313734
  • Pipeline finished with Success
    about 1 month ago
    Total: 210s
    #316984
  • Pipeline finished with Success
    11 days ago
    Total: 156s
    #335761
  • Pipeline finished with Success
    7 days ago
    Total: 173s
    #339404
  • Pipeline finished with Success
    7 days ago
    Total: 257s
    #339411
  • Pipeline finished with Skipped
    7 days ago
    #339423
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024