- Issue created by @partdigital
- ๐ฎ๐ณIndia pradhumanjainOSL
pradhumanjain2311 โ made their first commit to this issueโs fork.
- Merge request !408Issue #3443218: Gin is overriding title on custom entity forms โ (Open) created by Unnamed author
- Status changed to Needs review
8 months ago 6:10pm 26 April 2024 - Status changed to Needs work
8 months ago 7:33pm 26 April 2024 - ๐จ๐ญSwitzerland saschaeggi Zurich
The behavior is as expected here as the tabs are part of that entity. We'll implement something similar in core for Claro.
Note that Gin is always ahead of Claro as we test features out first.
Regarding the message: From a UX POV it should appear right before (above) the action buttons in the content area.
- ๐บ๐ธUnited States partdigital
The behavior is as expected here as the tabs are part of that entity.
Won't this break the messaging for other contrib modules that add custom tabs to the entity? It is a feature that works in Claro, Seven and other admin themes.
Regarding the message: From a UX POV it should appear right before (above) the action buttons in the content area.
It's currently rendering the message the same way as the "Delete" action, it just doesn't have the "This cannot be undone" message. (see screen shot for comparison).
FWIW I think the MR is not the right approach. Do we know exactly which routes we want to only render the title?
- ๐บ๐ธUnited States partdigital
partdigital โ changed the visibility of the branch 3443218-gin-is-overriding to hidden.
- Merge request !419Issue #3443218: Gin is overriding title on custom entity forms. โ (Open) created by partdigital
- ๐บ๐ธUnited States partdigital
I've opened an MR with part of that code removed. (It's what we're using on our project). But I'm open to other approaches as well. For example, perhaps we could be inclusive instead of exclusive. This would be a safer approach.
$override_routes = [ 'entity.node.canonical', 'entity.node.preview', 'entity.node.version_history', ]; if ($node->isDefaultTranslation() && n_array($matches[0], $override_routes) { $variables['title'] = $node->getTitle(); }
- Status changed to Needs review
7 months ago 4:24pm 14 May 2024 - Status changed to RTBC
3 months ago 9:02am 27 September 2024 i have applied the MR manually and found the issue is resolved title is changing now
- ๐จ๐ญSwitzerland saschaeggi Zurich
I'm moving this one back to needs work as I found one issue with the change:
It adds the meta information ("English translation") for the default language back. We explicitly removed this from the UI for the default language as it's not a translation: