- Issue created by @catch
- Status changed to Needs review
8 months ago 9:36am 24 April 2024 - 🇬🇧United Kingdom catch
Anonymous performance tests show the improvement in cache hit rate - one less cache set.
- Merge request !7687Filter irrelevant libraries before building the cache ID. → (Open) created by catch
- Status changed to Needs work
8 months ago 1:42pm 24 April 2024 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
8 months ago 3:36pm 24 April 2024 - Status changed to RTBC
8 months ago 6:03pm 26 April 2024 - 🇺🇸United States smustgrave
Not entirely sure how to best test this
So going to lean on PerformanceTest change that show the count go down
All threads appear to be answered.
Tests are all green
So going to go out on a limb and mark it, apologize if there is a better way to test.
- 🇬🇧United Kingdom catch
📌 Return early in AssetResolver::getJsAssets() and AssetResolver::getCssAssets() when there are no libraries to load Needs review was manually testable because it changed the query string on asset aggregate URLs, but this one isn't really - purely a caching optimization internal to the class.
-
alexpott →
committed 7cfb8bbd on 10.3.x
Issue #3443108 by catch: Optimize AssetResolver caching (cherry picked...
-
alexpott →
committed 7cfb8bbd on 10.3.x
-
alexpott →
committed 181827af on 11.x
Issue #3443108 by catch: Optimize AssetResolver caching
-
alexpott →
committed 181827af on 11.x
- Status changed to Fixed
8 months ago 7:30am 29 April 2024 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed 181827afe6 to 11.x and 7cfb8bbd48 to 10.3.x. Thanks!
-
alexpott →
committed 181827af on 11.0.x
Issue #3443108 by catch: Optimize AssetResolver caching
-
alexpott →
committed 181827af on 11.0.x
Automatically closed - issue fixed for 2 weeks with no activity.