Configuration for using Gitlab CI is missing

Created on 23 April 2024, 12 months ago
Updated 8 May 2024, 11 months ago

Problem/Motivation

There is no GitLab CI configuration for this module. This means we cannot run tests for merge requests. Additionally the test settings for DrupalCI are out of date and do not include a test for a supported version of Drupal.

Proposed resolution

Create a .gitlab-ci.yml file in the module's root folder using the following as a guide:
https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr...

Unsure if there are any additional settings needed or if the default template is sufficient.

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States rhovland Oregon

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @rhovland
  • 🇺🇸United States rhovland Oregon

    Also the default branch in gitlab for this project is 7.x-1.x instead of the current branch

  • Merge request !13Add the default GitLab CI configuration file → (Merged) created by rhovland
  • Pipeline finished with Failed
    12 months ago
    Total: 211s
    #154826
  • 🇺🇸United States rhovland Oregon

    Tests failing. They are the same failures experienced with Drupal CI manually configured to test D10 with PHP8.1

    Failing Drupal CI test results:
    https://www.drupal.org/pift-ci-job/2886512

    Failing GitLab CI test results:
    https://git.drupalcode.org/issue/commerce_authnet-3443033/-/jobs/1411481

  • Pipeline finished with Failed
    12 months ago
    #154849
  • Pipeline finished with Failed
    12 months ago
    Total: 211s
    #154854
  • Pipeline finished with Success
    12 months ago
    Total: 210s
    #154859
  • Status changed to Needs review 12 months ago
  • 🇺🇸United States rhovland Oregon

    PHPUnit tests are now passing. Please review for commit.

    Note one of the errors was in
    tests/src/FunctionalJavascript/ConfigurationFormTest.php/testCreateAcceptJsGateway()
    where it was asserting if Ajax completed but the option it was selecting is the default option in the default installation so ajax never runs. I changed the test to only click on the radio and assert ajax ran only if the radio button wasn't already selected.

    The other functional javascript errors were related to setting the status radio to a non-valid type. They were all changed to '1' (Enabled).

    The kernel test failures were a D9 depreciation where getModuleUpdateFunctions() needed to be changed to getUpdateFunctions()

  • Status changed to Fixed 12 months ago
  • 🇮🇱Israel jsacksick

    Thank you, merged!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024