- Issue created by @aleevas
- Merge request !11Issue #3442914: Add an override for font-family rule β (Merged) created by aleevas
- Status changed to RTBC
7 months ago 1:35pm 23 April 2024 - πΊπ¦Ukraine rolki
The changes look logical.
Argument for the community: In cases where the module changes the color scheme for everything, these changes must be forced, as it makes no sense to do this in all other extensions. Accordingly, after changing the scheme or turning off the module, everything will return to its previous state.
Thanks!
-
aleevas β
committed af544f94 on 1.1.x
Issue #3442914: Add an override for font-family rule
-
aleevas β
committed af544f94 on 1.1.x
- Status changed to Needs work
7 months ago 1:59pm 24 April 2024 - πΊπΈUnited States froboy Chicago, IL
I disagree here. Making un-scoped changes to base HTML tags and
!important
can have unintended consequences across the Drupal admin, contextual links, and more. We should be more thoughtful about how to set these variables in our components in order to maintain the proper CSS cascade instead of overwriting it completely.I recommend we revert these changes.
-
podarok β
committed d6192cd9 on 1.1.x
Revert "Issue #3442914: Add an override for font-family rule" This...
-
podarok β
committed d6192cd9 on 1.1.x
- πΊπΈUnited States froboy Chicago, IL
I've merged https://git.drupalcode.org/project/ws_colorway_canada/-/merge_requests/12 and tagged 1.1.9 β .
- πΊπΈUnited States froboy Chicago, IL
froboy β changed the visibility of the branch 3442914-montserrat-override to hidden.
- πΊπΈUnited States froboy Chicago, IL
froboy β changed the visibility of the branch 3442914-montserrat-override to active.
- Merge request !13fix: Add body class and override fonts as many places as we can. β (Merged) created by froboy
- Status changed to RTBC
7 months ago 9:14pm 1 May 2024 - Status changed to Fixed
5 months ago 9:06pm 2 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.