Project update bot creates branches with names that are incompatible with tools

Created on 23 April 2024, about 2 months ago
Updated 15 May 2024, about 1 month ago

Problem/Motivation

I've just noticed that the Project Update Bot now creates branches, e.g. at πŸ“Œ Automated Drupal 11 compatibility fixes for entity_ui Needs review .

However, the branch name it uses, 'project-update-bot-only' is incompatible with tools that streamline working with d.org patches and workflows, because these typically rely on an issue number prefix in the branch name.

e.g.:

- https://github.com/joachim-n/drupal-project-contrib-development
- https://github.com/joachim-n/dorgflow

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Active

Component

Code

Created by

πŸ‡¬πŸ‡§United Kingdom joachim

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @joachim
  • πŸ‡³πŸ‡±Netherlands bbrala Netherlands

    Just noticed your update on your composer project. Sorry.

    Thing is we want to make as clear as possible that branch is not to work on, since it WILL be force pushed with updates.

    The issuefork is still the default name though? ;x

  • πŸ‡¬πŸ‡§United Kingdom joachim

    It looks like the bot also created a '3430259-automated-drupal-11' branch?

    > Thing is we want to make as clear as possible that branch is not to work on, since it WILL be force pushed with updates.

    Sure, but could it still have the prefix?

    Also, without the prefix, the different bot issues for 9/10/11 updates will all have the same branch name which will be a PITA for maintainers as well.

  • πŸ‡³πŸ‡±Netherlands bbrala Netherlands

    Although I agree with you, i'm weary to do this in the current cycle because of the mass renaming that will need to happen. It would also mean new mr's etc etc. :(

    I promise to improve this next cycle.

  • πŸ‡­πŸ‡ΊHungary Balu Ertl Budapest πŸ‡ͺπŸ‡Ί

    Glad that I found this ticket, your discussion answers my initial doubt about which branch of the shall I add my extra commits.

    Therefore I agree with #2: it should be crystal clear to everyone that the branch β€œproject-update-bot-only” is strictly reserved for the Bot exclusively, it should be considered β€œread-only” for humans. You can check what output the automation produced during its last run but the ultimate branch that gets merged at the end of the day is the ticket-number-prefixed one will be after all.

    β€œ[…] the different bot issues for 9/10/11 updates will all have the same branch name which will be a PITA”

    I don't see any problem here:

    • Upgrading to D10 β†’ a ticket opens for D10 β†’ a ticket-related repository created for D10 β†’ a ticket-number-prefixed branch to open a merge request with
    • Upgrading to D11 β†’ a ticket opens for D11 β†’ a ticket-related repository created for D11 β†’ a ticket-number-prefixed branch to open a merge request with
    • Upgrading to D12 β†’ a ticket opens for D12 β†’ you get the point…
Production build 0.69.0 2024