- Issue created by @DamienMcKenna
- Status changed to Needs review
8 months ago 10:42am 23 April 2024 - last update
8 months ago 3 pass - πΊπΈUnited States DamienMcKenna NH, USA
I think this covers it, but the variable definitions need to be double-checked.
- Status changed to Needs work
8 months ago 12:34pm 23 April 2024 - π¬π§United Kingdom joachim
+++ b/src/Form/EntityTabForm.php @@ -379,8 +386,12 @@ protected function getRouteForEntityPath($target_entity_type_id, $path_component + if (is_array($route_iterator)) { + return reset($route_iterator); + } + else { + return $route_iterator; + }
I don't understand this change.
getIterator() returns an iterator. We're supposed to be returning Route|null.
How can we return $route_iterator?
- Status changed to Needs review
8 months ago 12:54pm 23 April 2024 - last update
8 months ago 3 pass - Status changed to Needs work
8 months ago 1:13pm 23 April 2024 - π¬π§United Kingdom joachim
seek() doesn't return anything. Maybe this should be current()?
- Status changed to Needs review
8 months ago 1:20pm 23 April 2024 - last update
8 months ago 3 pass - πΊπΈUnited States DamienMcKenna NH, USA
Yeah, sorry, I didn't think of checking the method's return statement.
- Status changed to Fixed
8 months ago 1:54pm 23 April 2024 -
joachim β
committed 4701df09 on 8.x-1.x
Issue #3442824 by DamienMcKenna: Updated for PHP 8.2 compatibility.
-
joachim β
committed 4701df09 on 8.x-1.x
Automatically closed - issue fixed for 2 weeks with no activity.