Contrib.social

Apply for joining as an co-maintainer

Open on Drupal.org →
Created on 22 April 2024, about 1 month ago
Updated 28 April 2024, about 1 month ago

Thanks for this module.

One of my project is currently consider using this module and maybe more projects to follow in the feature.

I have spent some time get myself familiar this module and SimpleSAMLphp.

I have reported some issues and suggestions to SimpleSAMLphp as well. For example https://github.com/simplesamlphp/simplesamlphp/issues/2042

I am wondering if you guys need a new co-maintainer for the feature development of this module?

I have managed some of Drupal modules and got some experience on maintaining Drupal modules.

If you still want a new co-maintainer, I am happy to join.

Thanks again.

📌 Task
Status

RTBC

Version

4.0

Component

Miscellaneous

Created by

🇦🇺Australia Mingsong 🇦🇺

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Mingsong
  • Status changed to RTBC about 1 month ago
  • Comment about 1 month ago →
    🇨🇭Switzerland Berdir Switzerland

    Turns out that I don't have permission to add new maintainers, but +1. We'll need to figure out who is allowed to do so.

    In the meantime, you're welcome to help already by reviewing issues as well as creating merge requests and other contributions. More tests would be amazing, not sure if real integration tests are possible?

    Once you are added as a maintainer, try to give other maintainers a chance to review changes and try to avoid committing your own non-trivial changes as much as possible.

  • Comment about 1 month ago →
    🇦🇺Australia Mingsong 🇦🇺

    Thanks @Sascha for your warm welcome.

    Yes, I think some real integration tests are important.

    I think we can learn something from samlauth module, regarding SMAL test integrating to a Drupal module.
    For example,
    https://git.drupalcode.org/project/samlauth/-/tree/8.x-3.x/test_resources

    Once you are added as a maintainer, try to give other maintainers a chance to review changes and try to avoid committing your own non-trivial changes as much as possible.

    Couldn't agree more. Yes, software development is a team work, communication is a key part for this job.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024