Deprecate and remove shepherd.js

Not sure whether we'll hit deprecation test errors on 10.3, or whether tour module already being deprecated means tests will continue to pass, hopefully the latter, otherwise we'll need to update the phpstan baseline.

Created a CR for the deprecation message to link to. This still needs an issue opened against the tour contrib module.

Nice work to have to MRs for both 10.3.x and 11.x... I think the big question is what about the tour contrib module. I guess it needs to include the shephard library like core did - but that's good because it can then update it on its own terms.

Once this is rtbc I'll commit.

I read both MRs and they are correct. I am not familiar with js deprecations so I checked the docs, https://www.drupal.org/about/core/policies/core-change-policies/drupal-d... → , and it matches. Well, except that this uses 'will be' instead of 'is' but that is not something to correct now as 'will be' exists in other examples on that page. In other words the policy itself is inconsistent. That is something to look at another day.

Forgot to add that I read the change record as well and it is fine, no changes needed.

11.x MR needs to also remove it from package.json (and yarn.lock), and vendor-update.js. There is also a CSS override in core/themes/olivero/css/components/button.pcss.css that can probably go at the same time?

Committed the deprecation to 10.3.x anyway, just needs work for the removal.

Good point. Ran 'yarn remove shepherd.js' and committed the results, and removed the section from vendor-update.js.

longwave → closed merge request !7636

Removed the icon CSS from Olivero as well.

CSS and copyright changes both look good.

Committed 5e376f3 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

Tagging to add the removal of the dependency to the release notes.