- Issue created by @j-barnes
- Status changed to Needs review
8 months ago 7:46pm 19 April 2024 - π©πͺGermany Hydra
Thx for your contribution @j-barnes!
The patch looks like it would fix the described bug and I will commit it.Does it make sense to show the empty Author item or should we remove it when there is no author? I did not reproduce the issue yet, but since you already had multiple use-cases, what is your opinion?
- πΊπΈUnited States j-barnes
j-barnes β changed the visibility of the branch 1.x to hidden.
- πΊπΈUnited States j-barnes
j-barnes β changed the visibility of the branch 1.x to active.
- πΊπΈUnited States j-barnes
j-barnes β changed the visibility of the branch 1.x to hidden.
- πΊπΈUnited States j-barnes
Good point, I think we may be better off just not showing in that case. Since assumptions cannot made for other entity types (besides nodes), let's add a check for the owner field, if one doesn't exist we can just not add the author metatags. I'll update the MR with this change.
- πΊπΈUnited States j-barnes
j-barnes β changed the visibility of the branch 3442183-removed-users-causes to hidden.
- πΊπΈUnited States j-barnes
j-barnes β changed the visibility of the branch 3442183-removed-users-causes to active.
-
Hydra β
committed 898afe71 on 1.0.x authored by
j-barnes β
Issue #3442183 by j-barnes: Removed users causes account name error
-
Hydra β
committed 898afe71 on 1.0.x authored by
j-barnes β
- Status changed to Fixed
8 months ago 6:50am 21 April 2024 - π©πͺGermany Hydra
Thats what I thought as well. Thanks for updating the MR :)
Automatically closed - issue fixed for 2 weeks with no activity.