Contrib.social

Move the local endpoint into a submodule

Open on Drupal.org →
Created on 19 April 2024, 2 months ago
Updated 26 April 2024, 2 months ago

Problem/Motivation

The local endpoint currently lives within the friendly captcha core module, but adds specific functionality, which is a nice bonus and should (from my perspective) be separated.

I think it just *is* something different, like client (core module) and server (local endpoint) that shouldn't be combined.
Furthermore this will make the feature more visible (in the module list), thereby better documented and also for security reasons it's an improvement to have the routes of this service disabled, if not used.

The update hook should simply enable the submodule, if the local endpoint is currently chosen. Otherwise, it could just inform about the new feature.

Hope it's okay to assign this to @jurgenhaas for feedback. I don't think it's urgent, but I'd really be happy to see this separated.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request
Status

Active

Version

1.0

Component

Code

Created by

🇩🇪Germany Anybody Porta Westfalica

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Anybody
  • Issue was unassigned.
  • Comment 2 months ago →
    🇩🇪Germany jurgenhaas Gottmadingen

    I wasn't feeling too well about the idea originally, but I could live with it. I'm just not convinced that the feature would get a better exposure that way.

    Now, if we decided to move it into its own module, I'd say we should then do 2 things:

    1. That separate module should be a submodule of friendlycaptcha and being delivered together with it.
    2. The local endpoint should then be removed from the settings form and the convention should be, if the local endpoint submodule is being enabled, this is the selected endpoint and can only be turned off by disabling that submodule again.

    And yes, an update hook to automatically enable it if it was selected before should also be included.

  • Comment 2 months ago →
    🇩🇪Germany Anybody Porta Westfalica

    @jurgenhaas 100% agree, that was exactly what I was thinking of.
    2. is discussable in UX, but I'm totally fine with that! :)

    I'm pretty sure it's better to separate this.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024