Add support for Navigation Beta 1+

Created on 18 April 2024, 8 months ago
Updated 18 May 2024, 7 months ago

Problem/Motivation

Adds support for Navigation Beta 1 and onwards

Steps to reproduce

Install the navigation module:
composer require 'drupal/navigation:^1.0@beta'

Proposed resolution

Works as expected

Note: We move the shortcuts to the topbar where we have located it for all our own toolbar variants. Otherwise this should have the same functionality as used without the Gin admin theme.

Remaining tasks

  • ✔️Base checks are in place
  • Code review if things can be done more elegantly
  • Programmatically remove all toolbar related libraries when Navigation is active
  • Testing! Does it work with Accent colors, Darkmode etc.

User interface changes

New navigation over steers Gin's Navigation options

API changes

Data model changes

📌 Task
Status

Fixed

Version

3.0

Component

User interface

Created by

🇨🇭Switzerland saschaeggi Zurich

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @saschaeggi
  • 🇨🇭Switzerland saschaeggi Zurich
  • Merge request !407Initial support for Navigation module Beta → (Merged) created by saschaeggi
  • 🇺🇸United States phenaproxima Massachusetts

    I tested this out and I see one glaring difference between Gin 3.x-dev with this patch, and Claro:

    With Claro/Olivero:

    With Gin:

    As you can see, Gin is for some reason not displaying the Shortcuts sub-menu. That's important for my project. Am I missing something here, or is there a bug in Gin?

  • 🇺🇸United States phenaproxima Massachusetts

    Ah -- never mind. Gin moves the Shortcuts list to the top bar, which is a legitimate design decision.

    Okay, I can't find anything to fault!

  • 🇨🇭Switzerland saschaeggi Zurich

    @phenaproxima I've updated the description to reflect that, sorry forgot to mention that.

  • 🇺🇸United States phenaproxima Massachusetts

    Makes sense if it's an intentional design decision.

    But the problem I'm having is the inconsistency. After all, the navigation will still appear when the front-end theme is active; elements should not move out of the navigation when viewing it in the frontend theme, because the navigation is fundamentally an administrative element of the page, regardless of theme.

    Is there a way to make Gin not move the shortcuts around? If not, could that be added as a setting?

  • 🇨🇭Switzerland saschaeggi Zurich

    @phenaproxima no inconsistencies introduced here, rather eliminated as all our other navigation (toolbar) options use the same. You'll need our companion module (gin_toolbar) anyway to use Gin's option in your frontend theme.

  • 🇺🇸United States phenaproxima Massachusetts

    OK, with some guidance from @saschaeggi I was able to confirm that, with Gin Toolbar installed, the shortcuts always appear in the top bar, even in the frontend theme. So indeed, no inconsistencies if everything's set up correctly.

    As far as I can tell, this patch is good to go!

  • 🇨🇭Switzerland saschaeggi Zurich
  • Status changed to Fixed 8 months ago
  • 🇨🇭Switzerland saschaeggi Zurich
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024