Improve healthcheck endpoint to allow caching and passing secret via query

needs review

thx, this seems pretty solid. I added a few small remarks

trying to summarize changes better in a short sentence, what about that?

Remarks are fixed.

If you have http_cache_control module installed, you need this patch: 🐛 Allow s-maxage to be overridden RTBC

patch looks mostly great! however, the url cache context for the new query parameter is missing. Added it and slightly refactored the PR to reduce code duplication.

I'm seeing this error:

The website encountered an unexpected error. Try again later.

TypeError: Drupal\ohdear_integration\Controller\OhDearIntegrationController::refineCacheMetadata(): Argument #1 ($cacheable_dependency) must be of type Drupal\ohdear_integration\Controller\RefinableCacheableDependencyInterface, Drupal\Core\Access\AccessResultAllowed given, called in /app/web/modules/contrib/ohdear_integration/src/Controller/OhDearIntegrationController.php on line 202 in Drupal\ohdear_integration\Controller\OhDearIntegrationController->refineCacheMetadata() (line 212 of modules/contrib/ohdear_integration/src/Controller/OhDearIntegrationController.php).

Drupal\ohdear_integration\Controller\OhDearIntegrationController->access(Object) (Line: 108)
Drupal\ohdear_integration\Controller\OhDearIntegrationController->Drupal\ohdear_integration\Controller\{closure}() (Line: 627)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 136)
Drupal\ohdear_integration\Controller\OhDearIntegrationController->buildJson()

Fixed php errors.

thx. changes look good + tested it successfully.

merged, fixed

Added to 2.0.1 release.

Automatically closed - issue fixed for 2 weeks with no activity.