- Issue created by @ptmkenny
- last update
12 months ago 113 pass - Status changed to Needs review
12 months ago 11:22am 18 April 2024 - Status changed to Postponed: needs info
12 months ago 10:49am 20 April 2024 - 🇳🇱Netherlands megachriz
I wonder if we should change this. Drupal 10 uses
$this->assertEquals()
all over the place.Perhaps that it is required in a future version of PHP/Drupal? Is there a Drupal core issue that suggests to change this?
- 🇯🇵Japan ptmkenny
Hmm, I made this change in all my own code since I trust PHPStorm :), but upon looking into it more, there is no consensus about this in core: #3029358: Change tests calling static methods as '$this->' to 'static::' →
Also, Commerce punted the decision to core and decided to leave it in place: #3029321: Change tests calling static methods as '$this->' to 'static::' →
So, I'll go ahead and close this now until the core policy changes.
- Status changed to Closed: won't fix
12 months ago 11:03am 20 April 2024