Fix PHPStan issues

I merged 8.x-1.x into the MR to see what that does for the tests on GitLab Ci.

So the remaining issues are all related to legacy tests/already addressed deprecations except this:

 ------ ---------------------------------------------------------------------- 
  Line   src/JmesRuntimeFactory.php                                            
 ------ ---------------------------------------------------------------------- 
  27     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
  61     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
  66     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
  102    \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                             

Once this gets fixed this MR should be ready.

I added the DI for JmesRuntimeFactory, but now the tests need updated. I don't understand how to do the mocks for the newly injected dependencies so setting to "Needs work."

MegaChriz → changed the visibility of the branch phpstan to hidden.

MegaChriz → changed the visibility of the branch phpstan to active.

It looks like it is passing tests again! It doesn't fix all PHPStan issues yet, but some can indeed be handled in one of the related issues.

Just waiting to see if tests pass on D9 too.

I merged the code!

Automatically closed - issue fixed for 2 weeks with no activity.