- Issue created by @alexpott
- π¬π§United Kingdom alexpott πͺπΊπ
We can't do the merge idea because merge is implemented as a select and update or insert... so yet another opportunity for races... so we can consider using upsert or using the lock system.
- Status changed to Needs review
5 months ago 10:10pm 17 April 2024 - Status changed to RTBC
5 months ago 3:55pm 22 April 2024 - πΊπΈUnited States smustgrave
Wasn't sure how to trigger the lock but applying the MR on the site we are using on and locks still appear to be working just fine. So going to lean on that.
- π¬π§United Kingdom alexpott πͺπΊπ
I've tried to write a test for this - both low level and and high level - using pcntl_fork() to simultaneously lock via the API and UI neither worked because it is hard to have multiple sessions as the same time in FunctionalTests and separate service instances in kernel tests.
-
alexpott β
committed a6ce9ee2 on 8.x-2.x
Issue #3441549 by alexpott: Race condition in \Drupal\content_lock\...
-
alexpott β
committed a6ce9ee2 on 8.x-2.x
- Status changed to Fixed
4 months ago 11:27am 30 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.