Fix new issues reported by PHPStan after extra rules

Created on 17 April 2024, 12 months ago

Updated 1 May 2024, 12 months ago

Problem/Motivation

After adding 📌 Add extra PHPStan rules Fixed , PHPStan reports extra issues which is good. But we need to solve them.
See https://git.drupalcode.org/project/domain_menu_access/-/jobs/1348415

 ------ --------------------------------------------------------------- 
  Line   domain_menu_access.install                                     
 ------ --------------------------------------------------------------- 
  66     Construct empty() is not allowed. Use more strict comparison.  
 ------ --------------------------------------------------------------- 
 ------ --------------------------------------------------------------- 
  Line   domain_menu_access.module                                      
 ------ --------------------------------------------------------------- 
  35     Call to function in_array() requires parameter #3 to be set.   
  35     Construct empty() is not allowed. Use more strict comparison.  
  81     Construct empty() is not allowed. Use more strict comparison.  
  101    Call to function in_array() requires parameter #3 to be set.   
  101    Construct empty() is not allowed. Use more strict comparison.  
 ------ --------------------------------------------------------------- 
 ------ ------------------------------------------------------------------------------------------ 
  Line   modules/domain_menu_access_menu_block/src/Plugin/Block/DomainMenuAccessMenuMenuBlock.php  
 ------ ------------------------------------------------------------------------------------------ 
  121    Loose comparison via "==" is not allowed.                                                 
         💡 Use strict comparison via "===" instead.                                               
  148    Construct empty() is not allowed. Use more strict comparison.                             
  185    Construct empty() is not allowed. Use more strict comparison.                             
  190    Short ternary operator is not allowed. Use null coalesce operator if                      
         applicable or consider using long ternary.                                                
  196    Construct empty() is not allowed. Use more strict comparison.                             
  229    Call to function in_array() requires parameter #3 to be set.                              
 ------ ------------------------------------------------------------------------------------------ 
 ------ --------------------------------------------------------------- 
  Line   src/Form/DomainMenuAccessSettingsForm.php                      
 ------ --------------------------------------------------------------- 
  67     Only booleans are allowed in a negated boolean, mixed given.   
  72     Construct empty() is not allowed. Use more strict comparison.  
  86     Call to function in_array() requires parameter #3 to be set.   
  101    Construct empty() is not allowed. Use more strict comparison.  
  101    Construct empty() is not allowed. Use more strict comparison.  
  105    Call to function in_array() requires parameter #3 to be set.   
 ------ --------------------------------------------------------------- 
 ------ --------------------------------------------------------------- 
  Line   src/Menu/DomainMenuLinkTreeManipulators.php                    
 ------ --------------------------------------------------------------- 
  137    Call to function in_array() requires parameter #3 to be set.   
  164    Construct empty() is not allowed. Use more strict comparison.  
  180    Construct empty() is not allowed. Use more strict comparison.  
 ------ --------------------------------------------------------------- 
 ------ -------------------------------------------------------------- 
  Line   src/Plugin/Block/DomainMenuAccessMenuBlock.php                
 ------ -------------------------------------------------------------- 
  126    Call to function in_array() requires parameter #3 to be set.  
 ------ -------------------------------------------------------------- 
 ------ -------------------------------------------------------------- 
  Line   src/Plugin/Derivative/DomainMenuAccessMenuBlock.php           
 ------ -------------------------------------------------------------- 
  55     Call to function in_array() requires parameter #3 to be set.  
 ------ -------------------------------------------------------------- 
 [ERROR] Found 23 errors

Steps to reproduce

Run PHPStan

Proposed resolution

Fix issues

Remaining tasks

Create MR

User interface changes

API changes

Data model changes

📌 Task

Status

Fixed

Version

2.0

Component

Code

Created by

🇧🇪Belgium tim-diels Belgium 🇧🇪

Live updates comments and jobs are added and updated live.

Merge Requests

!16Fix new issues reported by PHPStan after extra rules
Merged
🇧🇪Belgium tim-diels
updated 12 months ago

Comments & Activities

Issue created by @tim-diels
Comment 12 months ago →
🇧🇪Belgium tim-diels Belgium 🇧🇪
Merge request !16Fix new PHPStan issues → (Merged) created by tim-diels
Open in Jenkins → Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
1 pass
Issue was unassigned.
Status changed to Needs review 12 months ago2:15pm 17 April 2024
Comment 12 months ago →
🇧🇪Belgium tim-diels Belgium 🇧🇪
Made MR.
Comment 12 months ago →
System Message

tim-diels → committed 4dbd781e on 2.0.x
Issue #3441444 by tim-diels: Fix new issues reported by PHPStan after...
Status changed to Fixed 12 months ago2:52pm 17 April 2024
Comment 12 months ago →
🇧🇪Belgium tim-diels Belgium 🇧🇪
Comment 12 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024