Fix issues reported by PHPStan

------ ----------------------------------------------------------------------------------------------------- Line modules/domain_menu_access_menu_block/src/Plugin/Block/DomainMenuAccessMenuMenuBlock.php ------ ----------------------------------------------------------------------------------------------------- 20 Class Drupal\domain_menu_access_menu_block\Plugin\Block\DomainMenuAccessMenuMenuBlock extends unknown class Drupal\menu_block\Plugin\Block\MenuBlock. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols 20 Non-abstract class Drupal\domain_menu_access_menu_block\Plugin\Block\DomainMenuAccessMenuMenuBlock contains abstract method create() from interface Drupal\Core\Plugin\ContainerFactoryPluginInterface. 26 Call to an undefined method Drupal\domain_menu_access_menu_block\Plugin\Block\DomainMenuAccessMenuMenuBlock::getDerivativeId(). 30 Drupal\domain_menu_access_menu_block\Plugin\Block\DomainMenuAccessMenuMenuBlock::build() calls parent::build() but Drupal\domain_menu_access_menu_block\Plugin\Block\DomainMenuAccessMenuMenuBlock does not extend any class. 32 Access to an undefined property Drupal\domain_menu_access_menu_block\Plugin\Block\DomainMenuAccessMenuMenuBlock::$menuTree. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 35 Access to an undefined property Drupal\domain_menu_access_menu_block\Plugin\Block\DomainMenuAccessMenuMenuBlock::$configuration. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 36 Access to an undefined property Drupal\domain_menu_access_menu_block\Plugin\Block\DomainMenuAccessMenuMenuBlock::$configuration. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 40 Access to an undefined property Drupal\domain_menu_access_menu_block\Plugin\Block\DomainMenuAccessMenuMenuBlock::$configuration. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 41 Access to an undefined property Drupal\domain_menu_access_menu_block\Plugin\Block\DomainMenuAccessMenuMenuBlock::$configuration. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 42 Access to an undefined property Drupal\domain_menu_access_menu_block\Plugin\Block\DomainMenuAccessMenuMenuBlock::$configuration. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 43 Access to an undefined property Drupal\domain_menu_access_menu_block\Plugin\Block\DomainMenuAccessMenuMenuBlock::$configuration. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 61 Access to an undefined property Drupal\domain_menu_access_menu_block\Plugin\Block\DomainMenuAccessMenuMenuBlock::$menuTree. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 79 Access to an undefined property Drupal\domain_menu_access_menu_block\Plugin\Block\DomainMenuAccessMenuMenuBlock::$menuTree. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 99 Access to an undefined property Drupal\domain_menu_access_menu_block\Plugin\Block\DomainMenuAccessMenuMenuBlock::$menuTree. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 107 Access to an undefined property Drupal\domain_menu_access_menu_block\Plugin\Block\DomainMenuAccessMenuMenuBlock::$configuration. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 107 Access to an undefined property Drupal\domain_menu_access_menu_block\Plugin\Block\DomainMenuAccessMenuMenuBlock::$configuration. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 114 Access to an undefined property Drupal\domain_menu_access_menu_block\Plugin\Block\DomainMenuAccessMenuMenuBlock::$menuTree. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 128 Access to an undefined property Drupal\domain_menu_access_menu_block\Plugin\Block\DomainMenuAccessMenuMenuBlock::$menuTree. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 135 Access to an undefined property Drupal\domain_menu_access_menu_block\Plugin\Block\DomainMenuAccessMenuMenuBlock::$menuTree. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 136 Access to an undefined property Drupal\domain_menu_access_menu_block\Plugin\Block\DomainMenuAccessMenuMenuBlock::$menuTree. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 144 Call to an undefined method Drupal\domain_menu_access_menu_block\Plugin\Block\DomainMenuAccessMenuMenuBlock::getBlockLabel(). 144 Call to an undefined method Drupal\domain_menu_access_menu_block\Plugin\Block\DomainMenuAccessMenuMenuBlock::label(). 152 Access to an undefined property Drupal\domain_menu_access_menu_block\Plugin\Block\DomainMenuAccessMenuMenuBlock::$configuration. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 180 \Drupal calls should be avoided in classes, use dependency injection instead 190 Drupal\domain_menu_access_menu_block\Plugin\Block\DomainMenuAccessMenuMenuBlock::getCacheContexts() calls parent::getCacheContexts() but Drupal\domain_menu_access_menu_block\Plugin\Block\DomainMenuAccessMenuMenuBlock does not extend any class. ------ ----------------------------------------------------------------------------------------------------- ------ ---------------------------------------------------------------------- Line src/Plugin/Block/DomainMenuAccessMenuBlock.php ------ ---------------------------------------------------------------------- 68 \Drupal calls should be avoided in classes, use dependency injection instead ------ ---------------------------------------------------------------------- [ERROR] Found 26 errors

Comments & Activities

Issue created by @tim-diels
Merge request !11Add phpstan.neon → (Merged) created by tim-diels
Open in Jenkins → Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
1 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
1 pass

Comment 12 months ago →

🇧🇪Belgium tim-diels Belgium 🇧🇪

Added menu_block as dev requirement and reduces errors to:

 ------ ------------------------------------------------------------------------------------------ 
  Line   modules/domain_menu_access_menu_block/src/Plugin/Block/DomainMenuAccessMenuMenuBlock.php  
 ------ ------------------------------------------------------------------------------------------ 
  180    \Drupal calls should be avoided in classes, use dependency injection                      
         instead                                                                                   
 ------ ------------------------------------------------------------------------------------------ 
 ------ ---------------------------------------------------------------------- 
  Line   src/Plugin/Block/DomainMenuAccessMenuBlock.php                        
 ------ ---------------------------------------------------------------------- 
  68     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
 ------ ---------------------------------------------------------------------- 
 [ERROR] Found 2 errors

Open in Jenkins → Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
1 pass
Comment 12 months ago →
System Message

tim-diels → committed ce915e6d on 2.0.x
Issue #3441085 by tim-diels: Fix issues reported by PHPStan
Issue was unassigned.
Status changed to Fixed 12 months ago6:26am 16 April 2024
Comment 12 months ago →
🇧🇪Belgium tim-diels Belgium 🇧🇪
Comment 11 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix issues reported by PHPStan

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!11Fix issues reported by PHPStan
Merged

Comments & Activities

Fix issues reported by PHPStan

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!11Fix issues reported by PHPStanMerged

Comments & Activities

!11Fix issues reported by PHPStan
Merged