- Issue created by @arousseau
- 🇬🇧United Kingdom Eli-T Manchester
Good spot - just tested on 2.0.x and can recreate.
- Merge request !21#3441052: 🐛 fix bug where only one result with the same search attribute cannot be returned. → (Merged) created by Eli-T
- Status changed to Needs review
7 months ago 9:00am 3 May 2024 - 🇬🇧United Kingdom Eli-T Manchester
@arousseau does this fix work for you? Technically it's a BC break in case anyone was relying on the shape of this response, but as the module is alpha and has low usage I doubt this will cause problems for people.
- 🇫🇷France arousseau
Hello @eli-t thanks for this fix. I can confirm it is working.
It does break the two widgets added in #3315187 and #3314975, since the code uses array_flip to build the options for the form element.I'm not sure how to best fix this. The change in code is simple enough for those two issues, but I suppose it should wait before this one is merged first.
- Status changed to RTBC
3 months ago 4:05pm 2 September 2024 - Status changed to Fixed
3 months ago 4:08pm 2 September 2024 - 🇬🇧United Kingdom Eli-T Manchester
Thanks for testing @arousseau!
Merged to 2.0.x. Are you using this branch yet?
- Status changed to Needs work
3 months ago 4:15pm 2 September 2024 - 🇬🇧United Kingdom Eli-T Manchester
Merge train failed on PHPCS
https://git.drupalcode.org/project/jsonapi_reference/-/pipelines/271791/...
- Status changed to Fixed
3 months ago 9:55am 4 September 2024 - 🇬🇧United Kingdom Eli-T Manchester
New 2.0.0-alpha3 released to include this fix.
Release notes and project page warn about the BC break.
Automatically closed - issue fixed for 2 weeks with no activity.