Contrib.social

Don't lint the styles

Open on Drupal.org →
Created on 13 April 2024, 8 months ago
Updated 4 May 2024, 7 months ago

Problem/Motivation

Currently we have a style lint step in our CI process that's failing.

assets/css/sticky_local_tasks.css
  12:2   ✖  Expected "z-index" to come before "bottom"                         order/properties-order
  28:2   ✖  Expected "width" to come before "border-radius"                    order/properties-order
  32:39  ✖  Unexpected unit                                                    length-zero-no-unit
  32:51  ✖  Unexpected unit                                                    length-zero-no-unit
  33:24  ✖  Unexpected unit                                                    length-zero-no-unit
  33:36  ✖  Unexpected unit                                                    length-zero-no-unit
  34:2   ✖  Expected "transition" to come before "box-shadow"                  order/properties-order
  35:2   ✖  Expected "z-index" to come before "transition"                     order/properties-order
  38:2   ✖  Expected "display" to come before "line-height"                    order/properties-order
  44:14  ✖  Expected legacy color-function notation                            color-function-notation
  44:30  ✖  Expected "15%" to be "0.15"                                        alpha-value-notation
  44:36  ✖  Unexpected unit                                                    length-zero-no-unit
  44:49  ✖  Unexpected unit                                                    length-zero-no-unit
  45:3   ✖  Expected legacy color-function notation                            color-function-notation
  45:15  ✖  Expected "5%" to be "0.05"                                         alpha-value-notation
  45:20  ✖  Unexpected unit                                                    length-zero-no-unit
  45:32  ✖  Unexpected unit                                                    length-zero-no-unit
  46:2   ✖  Expected "background-color" to come before "box-shadow"            order/properties-order
  53:2   ✖  Expected "position" to come before "justify-content"               order/properties-order
  56:2   ✖  Expected "display" to come before "transition"                     order/properties-order
  66:2   ✖  Expected "padding" to come before "list-style"                     order/properties-order
  67:2   ✖  Expected "margin" to come before "padding"                         order/properties-order
  69:2   ✖  Expected "border-radius" to come before "background"               order/properties-order
  80:2   ✖  Expected "display" to come before "font-weight"                    order/properties-order
  82:2   ✖  Expected "align-items" to come before "justify-content"            order/properties-order
  83:2   ✖  Expected "position" to come before "align-items"                   order/properties-order
  93:2   ✖  Expected "position" to come before "white-space"                   order/properties-order
  95:2   ✖  Expected "z-index" to come before "font-size"                      order/properties-order
  97:2   ✖  Expected "right" to come before "opacity"                          order/properties-order
  99:2   ✖  Expected "display" to come before "height"                         order/properties-order
 106:2   ✖  Expected "right" to come before "font-size"                        order/properties-order
 108:2   ✖  Expected "padding" to come before "opacity"                        order/properties-order
 115:2   ✖  Expected "right" to come before "padding"                          order/properties-order
 128:2   ✖  Expected "background-repeat" to come before "background-position"  order/properties-order
 129:2   ✖  Expected "background-color" to come before "background-repeat"     order/properties-order
 131:2   ✖  Expected "display" to come before "background-size"                order/properties-order
 133:2   ✖  Expected "width" to come before "transition"                       order/properties-order
 242:12  ✖  Expected keyframe name "slideIn" to be kebab-case                  keyframes-name-pattern
 245:3   ✖  Expected "transform" to come before "opacity"                      order/properties-order
 253:12  ✖  Expected keyframe name "slideOut" to be kebab-case                 keyframes-name-pattern
 256:3   ✖  Expected "transform" to come before "opacity"                      order/properties-order
 260:3   ✖  Expected "transform" to come before "opacity"                      order/properties-order
42 problems (42 errors, 0 warnings)

https://git.drupalcode.org/project/sticky_local_tasks/-/jobs/1319323

Steps to reproduce

Proposed resolution

There are different options open to us:

  • Go along with the default linting config and update our styles.
  • Modify the linting config (see the Drupal GitLab CI stylelint help page for more details) and possibly also our styles.
  • Remove the linting step.

Remaining tasks

Choose a resolution and implement.

User interface changes

API changes

Data model changes

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

🇬🇧United Kingdom AndyF

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024