ReplaceOriginalHook not discovered

I just used this feature myself on another project in the last couple weeks, with success. This project is on v1.3.1.

The example code doesnt look right. (class namespacing, attribute' moduleName param)

What is the actual code/attributes you're using. and which hook from which module?

There are also tests for this.

> The example code doesnt look right. (class namespacing, attribute' moduleName param)

I replaced the module names as they're irrelevant for the issue and specific to the project where the issue was discovered, just as I removed the usual commenting you'd find in such code.

> There are also tests for this.

ReplacementOriginalHook isn't tested with autodiscovery of hook classes. The hook class is registered manually as a service: https://git.drupalcode.org/project/hux/-/blob/1.5.x/tests/modules/hux_re...

Note how the test is failing in the MR where I've changed it to autodiscorvery.

Right I got you.

but it didn't work until I added #[Hook('node_insert')] to the method too.

So what youre saying is it theoretically didnt work until you added a Hook/Alter to any method in the same class, not just the replace method.

In terms of fix, i believe we just need to update \Drupal\hux\HuxCompilerPass::getHuxClasses. We dont need to update the existing Replace test fixture.

Lets create a new autodiscovery-only Hooks class fixture, where it only has ReplacementOriginalHook implementations

I just used this feature myself on another project in the last couple weeks

I see now the class this is on also has adjacent Hooks and Alters.

> So what youre saying is it theoretically didnt work until you added a Hook/Alter to any method in the same class, not just the replace method.

Exactly. Or rather, not theoretically. I added the #[Hook('node_insert')] annotation to the same disable method that had the ReplaceOriginalHooks. That triggered the autodiscovery. So the method is both a replacement and a hook implementation. I didn't test whether that makes hux call it multiple times, but as the method does nothing it doesn't really matter i my case.

> In terms of fix, i believe we just need to update \Drupal\hux\HuxCompilerPass::getHuxClasses. We dont need to update the existing Replace test fixture.

Yeah, it was for demonstration purposes only. I do hope Gitlab will let me force push...

> Lets create a new autodiscovery-only Hooks class fixture, where it only has ReplacementOriginalHook implementations

For completeness sake it ought to have 3 classes, one for each autodiscovered annotation.

I'll whip something up...

Ah, on second thought, adding Alter and ReplaceOriginalHook to hux_auto_test is more proper.

Xen → changed the visibility of the branch 3440302-replaceoriginalhook-not-discovered to hidden.

Xen → changed the visibility of the branch 3440302-replaceoriginalhook-not-discovered to active.

There, added tests and fix.