Fix issues reported by PHPStan

Created on 11 April 2024, 8 months ago
Updated 29 April 2024, 8 months ago

Problem/Motivation

See https://git.drupalcode.org/project/domain_access_logo/-/jobs/1327524

Original:

------ ----------------------------------------------------------------------- 
  Line   src/DomainAccessLogo.php                                               
 ------ ----------------------------------------------------------------------- 
  55     Parameter $domain_negotiator of method                                 
         Drupal\domain_access_logo\DomainAccessLogo::__construct() has invalid  
         type Drupal\domain\DomainNegotiatorInterface.                          
 ------ ----------------------------------------------------------------------- 
 [ERROR] Found 1 error 

New:

 ------ --------------------------------------------------------------------- 
  Line   src/DomainAccessLogo.php                                             
 ------ --------------------------------------------------------------------- 
  72     Variable $current_domain in empty() always exists and is not falsy.  
 ------ --------------------------------------------------------------------- 
 [ERROR] Found 1 error 

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

🇧🇪Belgium tim-diels Belgium 🇧🇪

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024