- Issue created by @rodrigoaguilera
- Status changed to Postponed: needs info
7 months ago 3:49pm 22 May 2024 - πΊπΈUnited States smustgrave
There was a fix or two added around this can you verify on latest dev branch?
- Status changed to Closed: outdated
7 months ago 6:01pm 31 May 2024 - Status changed to Active
5 months ago 2:17pm 15 July 2024 - π©πͺGermany szeidler Berlin
The issue still appears for me in 6.0.6 which is identical to the current 6.0.x-dev.
- πͺπΈSpain rodrigoaguilera Barcelona
I was not able to look at this earlier.
The schema declares the placeholder as a non-translatable string.
https://git.drupalcode.org/project/better_exposed_filters/-/blob/7.0.x/c...It would be as simple as declaring it as label.
https://www.drupal.org/docs/drupal-apis/configuration-api/configuration-... βI think the value is not passed through the t() function anymore so we are good in that regard.
- Status changed to Needs review
5 months ago 3:13pm 15 July 2024 - πͺπΈSpain rodrigoaguilera Barcelona
Won't last forever but here is a 7.0.0-beta1 install with Spanish that won't translate the placeholder
https://master-frjqeydnocwhvedk7xbvevomt3dbpo03.tugboatqa.com/es/admin/c...And another instance with the same config but the patch from the MR applied
https://master-xzwomamjvwepxp4r3bai2ieaao8slmh8.tugboatqa.com/es/admin/c...Once the schema is changed the title is available on the interface
https://master-xzwomamjvwepxp4r3bai2ieaao8slmh8.tugboatqa.com/admin/stru...
- πͺπΈSpain rodrigoaguilera Barcelona
I also confirmed that the translation is not leaked into the interface translation system, therefore there is no wrapping t() of the string returned by the config_translation system.
In the case of the example installs from the previous comment it means that there is no Spanish strings available to translate into Spanish.
-
smustgrave β
committed 5d4e6158 on 7.0.x
Issue #3440172 by rodrigoaguilera: Placeholder text not translatable...
-
smustgrave β
committed 5d4e6158 on 7.0.x
- Status changed to Fixed
5 months ago 4:00pm 2 August 2024 - π§π·Brazil andre.bonon
andre.bonon β made their first commit to this issueβs fork.
- π§π·Brazil andre.bonon
I saw on the module's homepage "6.0.x = is the current active development branch and currently supports D9 + D10", so I'm re-rolling this fix to the 6.0.x too.
- Merge request !94Placeholder text not translatable using configuration translation β (Merged) created by andre.bonon
- π§π·Brazil andre.bonon
I'm uploading the fix as a patch so devs can use with composer.
- Status changed to Needs review
4 months ago 9:30pm 14 August 2024 - πΊπΈUnited States smustgrave
Iβm putting less effort into 6.0.x but if get around will look
- π§π·Brazil andre.bonon
I understand, however, there are some sites that, for their own reasons, cannot be upgraded to version 7 of the module.
I appreciate your effort, but this is about a single line already merged on 7.x. - Status changed to Fixed
4 months ago 7:17pm 24 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.