Review and define the back-end APIs of the experimental module

Created on 10 April 2024, 9 months ago
Updated 7 May 2024, 8 months ago

Problem/Motivation

In preparation for core inclusion, we need to define the back-end APIs of the experimental module. The navigation module will initially be marked as experimenal. Anything that is not an explicit API should be impossible to use as such. Mark dockblocks with @internal, make services private, turn classes or methods into final, make methods private.

Proposed resolution

Review back-end API's and consider the extent to which we should mark things as internal, by the above stated means.

Remaining tasks

MR please.

User interface changes

None.

API changes

Restricting back-end APIs to be internal as necessary. Lets list the eventual API changes here when we're at a good place.

Data model changes

None.

📌 Task
Status

Closed: outdated

Version

11.0 🔥

Component
Navigation 

Last updated 1 day ago

No maintainer
Created by

🇨🇦Canada m4olivei Grimsby, ON

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @m4olivei
  • 🇨🇦Canada m4olivei Grimsby, ON
  • 🇨🇦Canada m4olivei Grimsby, ON

    Useful for reference: https://www.drupal.org/about/core/policies/core-change-policies/bc-polic...

    Although from that page, note:

    Note that in addition to changes allowed here, Drupal 8 and above also includes experimental modules. These modules have their own versioning that does not follow semver (semantic versioning), and any APIs provided by such modules should be considered exempt from this policy.

    My read on that is marking our @internal APIs is not necessary for experimental inclusion, but will be necessary long term, as part of full non-experimental adoption into Drupal core.

  • First commit to issue fork.
  • 🇪🇸Spain plopesc Valladolid

    First iteration of the API definition marking some features as internal/final.

    Would be great to have a second pair of eyes on this to ensure that I understood it correctly.

    Thank you!

  • Pipeline finished with Success
    8 months ago
    #144600
  • Status changed to Needs review 8 months ago
  • 🇨🇦Canada m4olivei Grimsby, ON
  • 🇨🇦Canada m4olivei Grimsby, ON
  • Status changed to Needs work 8 months ago
  • 🇪🇸Spain ckrina Barcelona

    Moving to Needs work after getting Navigation into core.

  • Status changed to Closed: outdated 8 months ago
  • 🇨🇦Canada m4olivei Grimsby, ON

    Closing this issue as outdated. This came before the big change in the admin of Navigation over to layout builder. Most of the changes in the navigation contib MR here don't apply anymore. We can open specific follow up issues on an as needed basis for the current state of the navigation module codebase.

  • Pipeline finished with Canceled
    2 months ago
    Total: 85s
    #309473
  • Pipeline finished with Failed
    2 months ago
    Total: 333s
    #309474
  • Pipeline finished with Failed
    2 months ago
    Total: 4968s
    #311224
  • Pipeline finished with Failed
    2 months ago
    Total: 143s
    #311308
  • Pipeline finished with Failed
    2 months ago
    Total: 161s
    #311315
  • Pipeline finished with Success
    2 months ago
    #311330
  • Pipeline finished with Success
    2 months ago
    Total: 550s
    #311364
  • Pipeline finished with Success
    about 2 months ago
    Total: 265s
    #330352
  • Pipeline finished with Failed
    25 days ago
    Total: 1127s
    #351387
  • Pipeline finished with Skipped
    25 days ago
    #351874
Production build 0.71.5 2024