Fix PHPstan warning \Drupal calls should be avoided in classes

silvi.addweb → made their first commit to this issue’s fork.

Thanks for starting work on this. The change seem to remove the PHPStan warning, compare the updated job with scheduled pipeline job

However, the nightwatch tests now fail, whereas on the scheduled pipepline they pass.

Just rebased the MR. Same as before, PHPStan now passes but the Nighwatch tests fail. Does it need an argument in the .services.yml ?

jonathan1055 → changed the visibility of the branch 3439980-fix-phpstan-warning to hidden.

So, it did need the argument in .services.yml and because there is no short name/ alias defined in the core services file, it has to be the full class name

    arguments:
      - '@Drupal\Component\DependencyInjection\ReverseContainer'

This works now, Nightwatch tests pass and the pipeline is fully green. Ready for review.

Yup. Seems to be defined that way in core: https://git.drupalcode.org/project/drupal/-/blob/11.x/core/core.services...

Given that this project is part of the "gitlab_templates" downstream pipelines and that we want to keep the full pipeline green to avoid false errors upstream AND that the change is small and looks good, I'll merge this.

Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.