Cleanup all the code quality remaining issues

I've got cspell and phpcs now passing on this MR.

eslint is also passing locally, however it's not passing in CI. In CI we're getting the following error:

Oops! Something went wrong! :(
ESLint: 8.55.0
ESLint couldn't find the config "airbnb-base" to extend from. Please check that the name of the config is correct.
The config "airbnb-base" was referenced from the config file in "/builds/project/navigation/web/modules/custom/navigation/.eslintrc.json".

This error has been happening since we originally added Gitlab CI ✨ Add Gitlab CI integration Fixed . See the job run from back then.

There are others 📌 Fix ESLint on CI Active who have run into this. There is also an issue → filed against the Gitlab Templates project. I've commented there and will watch it.

Ideas to try

• Remove our eslint customizations and see what happens.
• Ignore eslint for now
• ???

Also noting that eslint config in CI just got a big-ish change a few days ago: #3432261: Eslint on contrib is making incorrect recommendations → .

As the eslint seems to be having larger issues that will take collaboration with the Gitlab Template project. Let's spin it off and not hold up the cleanup we were able to get done here. Follow up issue: 🐛 Eslint is failing with ESLint couldn't find the config "airbnb-base" to extend from Active .

LGTM. Good idea to spinoff the eslint fixes.

Great! Thanks. Merged to 1.x 🎉.

Automatically closed - issue fixed for 2 weeks with no activity.