Contrib.social

Multiple Icon Issues

Open on Drupal.org →
Created on 10 April 2024, 9 months ago

Problem/Motivation

Encountered multiple issues with the icons:

  • Email has the wrong icon for square
  • Email icon gets the class for brand icons. Needs to be solid.
  • Homepage icon uses the FA 5.x name ("home"). FA 6.x calls it "house".
  • Homepage icon gets the class for brand icons. Needs to be solid.
  • Spotify album and Spotify artist icon were coded to have a square icon. FA does not have a square spotify icon.
  • Instagram square icon was missing

Steps to reproduce

Proposed resolution

I updated the platform files where appropriate with the correct icon names.

I also added a new field to platform called iconSet. Most icons got set "fa-brands". Home and Email got iconSet = "fa-solid".

I supported this with additional logic in the FieldFormatter. The FieldFormatter was injecting a hardcoded value of 'fab' into the class for every icon. I replaced this with a dynamic value from the iconSet field. The default for the dynamic value is 'fa-brands'. So, any platform that does not have an iconSet value will get the same thing it had before my changes.

Also updated the README.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

2.0

Component

Code

Created by

🇺🇸United States JasonSafro

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024