Make the search block cacheable

Created on 10 April 2024, about 1 year ago

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Active

Version

2.0

Component

Code

Created by

πŸ‡¦πŸ‡ΊAustralia larowlan πŸ‡¦πŸ‡ΊπŸ.au GMT+10

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @larowlan
  • πŸ‡¦πŸ‡ΊAustralia geoffreyr Sydney, AU / Gadigal country

    We've been using this patch, but it's had the interesting side-effect of showing other users' unrelated search queries in cached search blocks. Need to dig into this a bit; maybe a custom cache context would help.

  • πŸ‡¦πŸ‡ΊAustralia larowlan πŸ‡¦πŸ‡ΊπŸ.au GMT+10

    Is that via the url params? if so we can add `url.query_args:%key` cache context where %key is the query param name from the url

  • πŸ‡¦πŸ‡ΊAustralia geoffreyr Sydney, AU / Gadigal country

    @larowlan Thanks, I'll give it a go.

  • Status changed to Needs review about 1 year ago
  • πŸ‡¦πŸ‡ΊAustralia geoffreyr Sydney, AU / Gadigal country

    We're using the MR with cache context in production right now. Works really well and haven't seen any issues with cached search queries.

  • πŸ‡¦πŸ‡ΊAustralia geoffreyr Sydney, AU / Gadigal country

    Adding a bit more to the description. I want to take a look at config changes before we look at RTBCing -- might be difficult to merge given how much else is coming through.

Production build 0.71.5 2024