Remove \Drupal\FunctionalTests\Core\Recipe\StandardRecipeTest::rebuildContainer()

I think this is just a case of extending core's Standard test so what I really think is necessary here is to improve the documentation.

What i could find here was to "hack" a little \Drupal\Tests\standard\Functional\StandardTest
Not sure how "hacky" it is ... but maybe will help to find cleanest solution to share the test code between Standard profile and recipe.

I would say there could be positive things like do not run module installer and rebuildContainer if not needed
and maybe it could help with others todo in StandardRecipeTest

but we'll see

I think if we move

    // Make sure the optional image styles are installed after enabling
    // the responsive_image module.
    \Drupal::service('module_installer')->install(['responsive_image']);
    $this->rebuildContainer();

into a protected method that was can override then we can still test with and without responsive image.

MR updated withe extra methods for overriding

Is it too much?

I thought maybe there could be other image styles for standard_responsive_images

@vasike yep too much - can we do #7.

@alexpott simplified as much as I could. I hope it's ok.

@vasike I've just pushed up the change that I think we should be making.

it will fail the recipe tests .. sorry

@alexpott thanks a lot for the support and guidance and patience.
and for solution

i think it's RTBC

Committed and pushed 027b0d72427 to 11.x and cee3acd2d18 to 10.3.x. Thanks!

vasike → closed merge request !111

Automatically closed - issue fixed for 2 weeks with no activity.