Refactor out dependency on Drupal core Search

Created on 9 April 2024, 8 months ago
Updated 18 April 2024, 7 months ago

Problem/Motivation

We don't know offhand why the Funnelback module depends on Drupal's core Search module. Seems to me that we could possibly refactor out the dependency and have Funnelback running on its own; would allow us to not have the core Search database tables hanging around unused.

There's probably good reasons for it, but I'd like to try and see if it can actually be done. Will update this issue as I find out more.

Steps to reproduce

Run any site installation with Funnelback. You need to have core Search enabled to use it.

Proposed resolution

Refactor it out. Start with removing the dependency, see what breaks, work our way down.

Remaining tasks

Implement the changes.

User interface changes

Hopefully none, depends on how much of core Search's forms and other search UI are used by Funnelback.

API changes

Depends on how tight core Search integration is.

Data model changes

Depends on how tight core Search integration is.

✨ Feature request
Status

Needs review

Version

2.0

Component

Code

Created by

πŸ‡¦πŸ‡ΊAustralia geoffreyr

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @geoffreyr
  • πŸ‡¦πŸ‡ΊAustralia geoffreyr

    A rough first pass indicates that Funnelback module really doesn't depend on Drupal core search at all. No hooks, no config, no permissions, nothing. I'm putting together a patch for myself which I'll soon contribute back here, but we may want to add an update hook to warn module end users that it no longer needs core Search and they should disable it for themselves if they like.

  • πŸ‡¦πŸ‡ΊAustralia larowlan πŸ‡¦πŸ‡ΊπŸ.au GMT+10

    I'd be happy just putting it in release notes fwiw - rather than an update hook

  • Merge request !83439549: Remove search dependency β†’ (Open) created by geoffreyr
  • Issue was unassigned.
  • Status changed to Needs review 7 months ago
  • πŸ‡¦πŸ‡ΊAustralia geoffreyr

    @larowlan Sounds fair enough. My MR is above but I expect it'll need more documentation, a changelog update, etc. Probably depends on when we want to cut a new release.

Production build 0.71.5 2024