Add type hints to WebAssert::address* and cleanUrl

Created on 9 April 2024, 2 months ago
Updated 30 April 2024, about 2 months ago

Problem/Motivation

Our addressEquals, addressNotEquals and cleanUrl functions support passing in a Url object but that is completely undocumented as they all inherit from the parent (mink's WebAssert). This also means static analysis doesn't think passing a Url is allowed.

Proposed resolution

Since we can use union types with a broader scope than the parent, we can add a parameter type of string|Url

User interface changes

N/A

API changes

Stricter parameters on addressEquals, addressNotEquals and cleanUrl.

Data model changes

N/A

Release notes snippet

📌 Task
Status

Fixed

Version

10.3

Component
PHPUnit 

Last updated about 2 hours ago

Created by

🇦🇺Australia acbramley

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.69.0 2024