- Issue created by @pdureau
- Assigned to oldeb
- π§πͺBelgium oldeb Namur π§πͺ
Added basic kernel tests for the ComponentPluginManager but following error is making them fail :
PHPUnit\Framework\Exception: PHP Deprecated: basename(): Passing null to parameter #1 ($path) of type string is deprecated in /var/www/html/web/core/lib/Drupal/Core/Theme/ComponentPluginManager.php on line 316
Deprecated: basename(): Passing null to parameter #1 ($path) of type string is deprecated in /var/www/html/web/core/lib/Drupal/Core/Theme/ComponentPluginManager.php on line 316
PHP Deprecated: basename(): Passing null to parameter #1 ($path) of type string is deprecated in /var/www/html/web/core/lib/Drupal/Core/Theme/ComponentPluginManager.php on line 316
Deprecated: basename(): Passing null to parameter #1 ($path) of type string is deprecated in /var/www/html/web/core/lib/Drupal/Core/Theme/ComponentPluginManager.php on line 316 - π«π·France pdureau Paris
It may be related to π [2.0.x] Ui Patterns library overview template nested components Active
- π§πͺBelgium oldeb Namur π§πͺ
- Fixed issue by overriding SDC's alterDefinition method in our own ComponentPluginManager.
- Fixed error in getCategories when no group is defined
- Adding sort on getGroupedDefinitions to have the group/categories in the same order as getCategories
- Status changed to Needs work
7 months ago 10:07am 2 May 2024 - π§πͺBelgium oldeb Namur π§πͺ
Added the following tests :
- PropTypeAdapterPluginManager::guessFromSchema()
- PropTypePluginManager::guessFromSchema()
- π©πͺGermany Christian.wiedemann
Christian.wiedemann β made their first commit to this issueβs fork.
- @oldeb opened merge request.
- π§πͺBelgium oldeb Namur π§πͺ
Finished, MR is blocked because ComponentPluginManager.php changed on both sides ...
Rebase is not helping :/ - @oldeb opened merge request.
- Status changed to Needs review
6 months ago 9:24am 15 May 2024 - π§πͺBelgium oldeb Namur π§πͺ
Created a new branch and rebased everything with the help of @Grimreaper.
Fixed an issue with the slots being arrays instead of objects. -
Christian.wiedemann β
committed 308ba9d3 on 2.0.x authored by
oldeb β
Issue #3439414 by oldeb, Christian.wiedemann: Unit tests plugins...
-
Christian.wiedemann β
committed 308ba9d3 on 2.0.x authored by
oldeb β
- Status changed to Fixed
6 months ago 9:36pm 22 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.