- Issue created by @lostcarpark
- Status changed to Needs review
over 1 year ago 1:04am 6 April 2024 - 🇮🇪Ireland lostcarpark
Fixed long line and whitespace issues.
Most of the changes are fairly self explanatory, except possibly the removal of a line of commented out code from
src/Plugin/views/argument/Date.php
.I checked
git blame
, and it reported the line was commented in 2022, so at present it seems unnecessary. - First commit to issue fork.
-
mandclu →
committed 9db9d967 on 4.1.x authored by
lostcarpark →
Issue #3439011 by lostcarpark: GitLab CI - PHPCS - Long lines and...
-
mandclu →
committed 9db9d967 on 4.1.x authored by
lostcarpark →
- Status changed to Fixed
over 1 year ago 10:10am 6 April 2024 - 🇨🇦Canada mandclu
Thanks for filing this @lostcarpark. Having reviewed the commented line of code, I believe that ultimately the token support was added as a separate argument default class, so it is fine to remove. It does also highlight that the Date Token should be removed from the argument schema file, so I have filed 📌 Remove "Token" from the argument schema Active for that work.
Automatically closed - issue fixed for 2 weeks with no activity.