[2.0.0-alpha2] UiPatternsSampleEntityGenerator: Access to an undefined property

Christian.wiedemann → made their first commit to this issue’s fork.

The variable is only available for Nodes. Right now I don't see any usecase to set the node to preview mode. I think we can remove it safely.

Proposals:

We duplicated SampleEntityGeneratorInterface from layout_builder module, so:

• let's add a comment to explain why we did the copy (to avoid a dependency to this module)
• let's add the variables typing

UiPatternsSampleEntityGenerator:

• Can you rename SampleEntityGenerator?
• And change the comment to not make people believe it is only related to Layout Builder.
• let's add the variables typing

thanks Christian for the update. It is 99% perfect.

Is it relevant to add the type of the parameters here?
public function get($entity_type_id, $bundle_id): EntityInterface;

and here?
public function delete($entity_type_id, $bundle_id) :SampleEntityGeneratorInterface;

Did you run?

phpcbf --standard=Drupal --extensions=php,module path/to/module
phpcs --standard=Drupal --extensions=php,module path/to/module

What does "successor" means here?
Generates a sample entity for use by the UI Patterns successors.

Can you rebase your MR?

Hi, I updated the types and the docs.

Automatically closed - issue fixed for 2 weeks with no activity.