- Issue created by @adelgado12
- last update
9 months ago 6 pass, 4 fail - last update
9 months ago 6 pass, 4 fail - last update
9 months ago 6 pass, 4 fail - last update
9 months ago 14 pass - Status changed to Needs review
9 months ago 7:43am 3 April 2024 - 🇫🇷France MacSim
Hi @adelgado12
Interesting feature request.
I personally prefer the hook proposition to the field proposition, especially because the field proposition would store entities ids in the settings and those ids might not exist or be different when we work with multiples environments.
- Status changed to Needs work
8 months ago 3:39pm 17 April 2024 - last update
8 months ago 14 pass - last update
8 months ago 6 pass, 2 fail - last update
8 months ago 14 pass - Status changed to Needs review
8 months ago 7:54am 8 May 2024 Hi @macsim
Good idea the hook proposition, i'm not sure event dispatcher is adpated because we can't see result on listener in process unlike hooks.
I changed the code to use a hook rather than the configuration field
-
macsim →
committed 55d3f0a4 on 2.0.x authored by
adelgado12 →
Resolve #3437556 "Exclude specific entities"
-
macsim →
committed 55d3f0a4 on 2.0.x authored by
adelgado12 →
- 🇫🇷France MacSim
Hi @adelgado
Sorry for the delay and thank you for the great job you've done here.
I merged your work on 2.0.x
Still need to port it on 3.1.x - 🇫🇷France MacSim
I am finally going to revert the commit made on 2.0.x cause it still needs some work
- line 12 in
index_now.api.php
should be removed - I didn't tested every use case before to merge (shame on me)
- For each entity type, we need to add a test that will cover the
FALSE
return onindex_now_is_indexable_entity()
function call (we'll check that the next function won't be call in those use cases). Those tests functions should be calledtest[ENTITY_TYPE]ExcludedByHook()
- line 12 in
- 71fa9947 committed on 2.0.x
Revert "Resolve #3437556 "Exclude specific entities"" This reverts...
- 71fa9947 committed on 2.0.x
- Status changed to Needs work
5 days ago 12:03am 18 December 2024