- Issue created by @ryanrobinson_wlu
- 🇺🇸United States tr Cascadia
Yes, deprecations are introduced into core all the time - this is just a normal part of keeping the module up-to-date, not a bug.
That's why we have automated testing - so we see these things. It's not necessary to post an issue for notices in the tests unless you want to provide a patch to address these issues.
The deprecation notices are simply notices that something will be changing in the future - in this case the current code is just fine and will be fine until Drupal 11.
Are you planning on providing a patch for this issue?
- First commit to issue fork.
- last update
9 months ago 293 pass, 45 fail - 🇺🇸United States tr Cascadia
The first issue is because of the core Drupal change made in RecursiveExtensionFilterIterator is deprecated →
The second one is a duplicate of your issue in 🐛 [10.2] PHPUnit errors: non-existent service plugin.manager.field.field_type_category Needs review , and there is a fix in that issue.
I have changed the issue title to reflect that the first one is the only one that needs to be addressed here.
- Assigned to ankitv18
- 🇮🇳India ankitv18
@TR getting this error when I'm trying to create branch
Failed to create branch '3437436-fix-deprecation': invalid reference name '4.0.x'
- Merge request !34Issue #3437436: Fix RecursiveExtensionFilterIterator is deprecated → (Merged) created by ankitv18
- Issue was unassigned.
- Status changed to Needs review
9 months ago 9:55am 25 June 2024 - Status changed to Needs work
9 months ago 5:25pm 25 June 2024 - 🇺🇸United States tr Cascadia
Two things:
- Don't need the conditional because 4.0.x is going to have a minimum of Drupal 10.3. (The requirements haven't been changed yet in composer.json because, with the other 10.3 problem, I don't want to people switching to 4.0.x yet until I know it's working in 10.3).
- You're not using the new class correctly. See the change notice at RecursiveExtensionFilterIterator is deprecated → for details.
- Status changed to Needs review
9 months ago 5:36pm 25 June 2024 - 🇮🇳India ankitv18
Alright, considering your feedback removed conditional statement and fixed the proper implementation as per change notice.
Earlier I went through the codebase to implement the approach. :( -
TR →
committed 7a1ebfd2 on 4.0.x authored by
ankitv18 →
Issue #3437436 by ankitv18: [10.2] RecursiveExtensionFilterIterator is...
-
TR →
committed 7a1ebfd2 on 4.0.x authored by
ankitv18 →
- Status changed to Fixed
9 months ago 6:09pm 25 June 2024 - 🇺🇸United States tr Cascadia
Thanks, looks good. I made some changes to the comments and merged.
Automatically closed - issue fixed for 2 weeks with no activity.