Add phpstan (max PHP version) job

I just made a really minor amend to the documentation file. I triggered a test for keycdn and the job is running as expected: https://git.drupalcode.org/project/keycdn/-/jobs/1209750 (this is running with PHP8.3).

I think it's RTBC given that I reviewed it and ran the above test. Happy for another pair of eyes to give a +1 or feedback.

I'd like to test this and review, will do tomorrow.

That'd be great @jonathan1055. I appreciate the extra testing.

I tested this with Module Filter
https://git.drupalcode.org/issue/module_filter-3437542/-/pipelines/135198

Jobs with current core version
Composer job log has Composer version 2.6.6 2023-12-08 18:32:26

Max php version
Composer job shows

Composer version 2.7.2 2024-03-11 17:12:18
PHP version 8.3.4 (/usr/local/bin/php)

Both the phpstan jobs pass, and there are no significant differences in the jobs logs. The phpstan version is 1.10.66 for both of them.

In the updated doc page we have "Consider the PHP version when interpreting the results of the PHPStan job, as the analysis may give different results between major versions of PHP." But in the PHPstan job log the PHP version is not very readily viewable. Maybe it would be nice to write one line where we show the PHPstan version to also show the PHP version? I can add this if you think it useful, therefore leaving this RTBC for now.

Good idea. Let's add it. Feel free to do it. As it's a one-line change, it can stay RTBC. I can wait until it's done.

Merged. Thanks @mscieszka and @jonathan1055. Marking as fixed.

I pushed the change and rested https://git.drupalcode.org/issue/module_filter-3437542/-/pipelines/135376
The phpstan for current version has

$ php vendor/bin/phpstan --version
PHPStan - PHP Static Analysis Tool 1.10.66
$ php --version
PHP 8.1.27 (cli) (built: Dec 23 2023 01:28:27) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.27, Copyright (c) Zend Technologies
    with Zend OPcache v8.1.27, Copyright (c), by Zend Technologies

and 'phpstan max php' has

 php vendor/bin/phpstan --version
PHPStan - PHP Static Analysis Tool 1.10.66
$ php --version
PHP 8.3.4 (cli) (built: Mar 14 2024 23:31:02) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.3.4, Copyright (c) Zend Technologies
    with Zend OPcache v8.3.4, Copyright (c), by Zend Technologies

I was writing this as you merged. All good.

Updated the project description to a more generic You can also run the PHPStan job and the tests jobs against different versions of Drupal.

Automatically closed - issue fixed for 2 weeks with no activity.